Json rpc diagnostics #124
Merged
Json rpc diagnostics #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kLabz
commented
Jul 2, 2024
•
kLabz
commented
- Use Json RPC diagnostics if available (added in [display] diagnostics as json rpc HaxeFoundation/haxe#11412)
- Removed (undocumented) populateCacheFromDisplay config, which is not needed with Json RPC diagnostics nor with recent nightlies; could technically be useful for older nightlies or 4.3.x but this hack has been removed so it's a bit of a PITA to continue to support it here
- Had to update tests because [js] Use native maps when ES6 is enabled. HaxeFoundation/haxe#11698 changed iteration order for js maps
- Added support for diagnostics on all open (Haxe) files in a single diagnostics request; can be disabled by config
- TODO followup: add support for this config in vshaxe
TODO: only when this method is available
Unless disabled by config
|
I'm not very familiar with this code but at a glance it looks good. |
Simn
approved these changes
Jul 2, 2024
AlexHaxe
reviewed
Jul 2, 2024
AlexHaxe
reviewed
Jul 3, 2024
src/haxeLanguageServer/features/haxe/codeAction/OrganizeImportsFeature.hx
Outdated
Show resolved
Hide resolved
|
I have only briefly run it on actual code, it seemed to work, but I haven't done any extensive testing. code style wise curlies around single line bodies are preferred, but you'll easily find samples of rule breaking code throughout the project, so not a big deal (it might summon a Gama11). other than that I see no blockers. |
19 tasks
|
I fixed the curlies and prepared HaxeFoundation/haxe#11707 for Json RPC diagnostics on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.